(293/308) 1891 - GitPlugin on macOS has several isssues #1: Missing or Wrong Status indicator

Please change in Status.java

public static final int UNMODIFIED = 0; // green

to

public static final int UNMODIFIED = 9; // green

This will ensure that every tracked file gets a full green icon when it wasn't touched. At the moment it won't get any icon at all. This is due to the fact that UNMODIFIED * 10 + UNMODIFIED = 0 at the moment and this happens to be the same value as "VC_STATUS_NORMAL", Setting "UNMODIFIED" to 9 makes sure we will never accidently get 0.

I've also changed now the creation of the icon. I personally find it easier to distinguish the combined icons when the separation is diagonally and not vertically. Especially the yellow icons are hard to recognize when you have a white background.

How can I file a pull request?

Can you attach a patch? I'd like to see the icons with the diagonal separation.

Oh, wait, I see the icons are actual image files, not generated. Can you just attach the image files?

Also, I don't know how you would file a pull request. I'm not much of a git user, most things I work on are using svn. Maybe someone else can answer that question. In the mean time, if you attach the image files here, I can get them put in the right place.

And last, I made your change of UNMODIFIED=9 in my local code, and I do like that better.

Hi Dale. I cannot atache the images as I changed the code. No more images required. The icons are actually drawn.

But do give you an impression, please see attached screenshot.

I also changed the colors a bit. But see my next other post for that.

Bildschirmfoto%202017-10-27%20um%2010.14.03.png (27.3Kio)

P.S. I also just managed to add color options to the option pane of the Git Plugin.

I think it could be worth a V0.8 ;)

- **assigned_to**: Dale Anson
- **Group**: -->